Skip to content

feat(timeseries): remove stream style for bar charts #37532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuisSanchez wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(timeseries): remove stream style for bar charts #37532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0d9584
feat(timeseries): remove stream style for bar charts
LuisSanchez Jan 28, 2026
52f297c
chore(controlPanel): prettier format
LuisSanchez Jan 29, 2026
0e23455
refactor(chart): introduce StackControlOptionsWithoutStream for bar c…
LuisSanchez Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
minorTicks,
richTooltipSection,
seriesOrderSection,
showValueSection,
showValueSectionWithoutStream,
truncateXAxis,
xAxisBounds,
xAxisLabelRotation,
Expand Down Expand Up @@ -325,7 +325,7 @@ const config: ControlPanelConfig = {
...seriesOrderSection,
['color_scheme'],
['time_shift_color'],
...showValueSection,
...showValueSectionWithoutStream,
[
{
name: 'stackDimension',
Expand Down Expand Up @@ -373,11 +373,18 @@ const config: ControlPanelConfig = {
],
},
],
formDataOverrides: formData => ({
...formData,
metrics: getStandardizedControls().popAllMetrics(),
groupby: getStandardizedControls().popAllColumns(),
}),
formDataOverrides: formData => {
// Reset stack to null if it's Stream when switching to Bar chart
const formDataWithStack = formData as Record<string, unknown>;
return {
...formData,
metrics: getStandardizedControls().popAllMetrics(),
groupby: getStandardizedControls().popAllColumns(),
...(formDataWithStack.stack === StackControlsValue.Stream && {
stack: null,
}),
};
},
};

export default config;
8 changes: 8 additions & 0 deletions superset-frontend/plugins/plugin-chart-echarts/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ export const AreaChartStackControlOptions: [
Exclude<ReactNode, null | undefined | boolean>,
][] = [...StackControlOptions, [StackControlsValue.Expand, t('Expand')]];

export const StackControlOptionsWithoutStream: [
JsonValue,
Exclude<ReactNode, null | undefined | boolean>,
][] = [
[null, t('None')],
[StackControlsValue.Stack, t('Stack')],
];

export const TIMEGRAIN_TO_TIMESTAMP = {
[TimeGranularity.HOUR]: 3600 * 1000,
[TimeGranularity.DAY]: 3600 * 1000 * 24,
Expand Down
21 changes: 20 additions & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ import {
SORT_SERIES_CHOICES,
sharedControls,
} from '@superset-ui/chart-controls';
import { DEFAULT_LEGEND_FORM_DATA, StackControlOptions } from './constants';
import {
DEFAULT_LEGEND_FORM_DATA,
StackControlOptions,
StackControlOptionsWithoutStream,
} from './constants';
import { DEFAULT_FORM_DATA } from './Timeseries/constants';
import { defaultXAxis } from './defaults';

Expand Down Expand Up @@ -148,6 +152,14 @@ export const stackControl: ControlSetItem = {
},
};

export const stackControlWithoutStream: ControlSetItem = {
...stackControl,
config: {
...stackControl.config,
choices: StackControlOptionsWithoutStream,
},
};

export const onlyTotalControl: ControlSetItem = {
name: 'only_total',
config: {
Expand Down Expand Up @@ -193,6 +205,13 @@ export const showValueSectionWithoutStack: ControlSetRow[] = [
[onlyTotalControl],
];

export const showValueSectionWithoutStream: ControlSetRow[] = [
[showValueControl],
[stackControlWithoutStream],
[onlyTotalControl],
[percentageThresholdControl],
];

const richTooltipControl: ControlSetItem = {
name: 'rich_tooltip',
config: {
Expand Down
Loading
Loading