Skip to content

Conversation

@connorshea
Copy link
Contributor

@connorshea connorshea commented Dec 30, 2025

User description

SUMMARY

This will ensure that the schema path actually exists and matches the current version of oxlint, rather than the previous situation, wherein the JSON Schema referenced does not actually exist.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Ensure that opening this file in an editor that supports JSON Schemas (e.g. VS Code) works and doesn't highlight any problems (assuming the package is installed).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CodeAnt-AI Description

Use local oxlint schema for editor validation

What Changed

  • oxlint.json now points to the local schema file in node_modules instead of a remote URL
  • Editors (e.g., VS Code) will find the schema and stop showing "schema not found" or mismatched-schema warnings when opening oxlint.json
  • Schema validation now reflects the installed oxlint package version and works without network access

Impact

✅ Clearer editor validation
✅ Fewer schema-not-found warnings
✅ Schema matches installed oxlint version

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

This will ensure that the schema path actually exists and matches the current version of oxlint.
@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Dec 30, 2025

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Dec 30, 2025
@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Dec 30, 2025
@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI finished reviewing your PR.

@codeant-ai-for-open-source
Copy link
Contributor

💡 Enhance Your PR Reviews

We noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow:

🚦 Quality Gates

Status: Quality Gates are not enabled at the organization level
Learn more about Quality Gates

🎫 Jira Ticket Compliance

Status: Jira credentials file not found. Please configure Jira integration in your settings
Learn more about Jira Integration

⚙️ Custom Rules

Status: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository
Learn more about Custom Rules


Want to enable these features? Contact your organization admin or check our documentation for setup instructions.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the oxlint configuration to reference a local schema file instead of a remote URL, ensuring the schema matches the installed oxlint version and works offline.

  • Changes the $schema reference in oxlint.json from a remote GitHub URL to a local file in node_modules
  • Improves editor validation by ensuring the schema file actually exists and matches the installed oxlint version (^1.32.0)

@@ -1,5 +1,5 @@
{
"$schema": "https://oxc-project.github.io/oxlint/schema.json",
"$schema": "./node_modules/oxlint/configuration_schema.json",
Copy link

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema path uses ./node_modules/ while the existing lerna.json file in the same directory uses node_modules/ (without the leading ./). For consistency with the existing configuration pattern in this repository, consider removing the ./ prefix to match the style used in lerna.json.

Suggested change
"$schema": "./node_modules/oxlint/configuration_schema.json",
"$schema": "node_modules/oxlint/configuration_schema.json",

Copilot uses AI. Check for mistakes.
@sadpandajoe sadpandajoe merged commit 70b2e52 into apache:master Jan 8, 2026
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants