Skip to content

fix: AceEditor Autocomplete Highlight #35316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: AceEditor Autocomplete Highlight #35316

wants to merge 1 commit into from
+5 −0

Conversation

geido
Copy link
Member

@geido geido commented Sep 27, 2025

SUMMARY

Fixes #35313

AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2025-09-27 at 14 07 45

TESTING INSTRUCTIONS

  1. Visit SQL Lab
  2. Change the SQL in the editor so that the autocomplete appears
  3. Highlight text should be visible in both dark and light mode

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

korbit-ai[bot]
korbit-ai bot reviewed Sep 27, 2025
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned ​
File Path Reviewed
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx ✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@dosubot dosubot bot added change:frontend Requires changing the frontend sqllab Namespace | Anything related to the SQL Lab labels Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@korbit-ai korbit-ai[bot] korbit-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend size/XS sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete matched text in SQL Lab is unreadable in dark theme (black on black)
1 participant
@geido