fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl #35298
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The APP_ICON configuration variable was deprecated in PR #31590 (Ant Design v5 theming overhaul) but this breaking change was not documented in UPDATING.md. Users were confused when their custom logos stopped working in Superset 6.0.0rc1. Added clear migration instructions showing how to replace APP_ICON with the new THEME_DEFAULT.token.brandLogoUrl configuration. Resolves misconceptions about APP_ICON functionality mentioned in issue #34824. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
Ok I can do it as part of this PR too and just change the UPDATING to that. |
|
A side note here, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Documented the deprecation of APP_ICON configuration variable in favor of the new theme-based logo system introduced in PR #31590. This breaking change was causing confusion for users upgrading to Superset 6.0.0rc1 who found their custom logos no longer working.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION