feat(viz/echart): allow enforcing line style for Timeseries chart

[hainenber]

feat(viz/echart): allow enforcing line style for Timeseries chart

SUMMARY

Allow users to enforce a line style for their Timeseries chart such as dotted or dashed. Interesting feature request from a Slack user

Demo

Screen.Recording.2025-02-14.at.12.25.57.mov

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts	✅
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts	✅
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx	✅
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[sadpandajoe]

Normally we use dotted or dashed for a time shift line, would this be confusing for the user if they used this for the regular line?

[hainenber]

By defaut, there isnt any enforcement for overriding line style. People with intention will configure it by themselves so no changes to previous behavior.

[rusackas]

I think @sadpandajoe is concerned that if a user picks dashed for the main series, then time shift is also dotted, with no means to change it. This would indeed be confusing. If there could be a (conditionally rendered) control to pick the line style for time shift lines, that would be a win in my book!