Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrating easy-to-migrate AntD vanilla components #32010

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mistercrunch
Copy link
Member

Pushing these easy-to-migrate components, hoping to get through a CI run, and that we can fire up an ephemeral environment and make is easier to do a manual review.

@mistercrunch
Copy link
Member Author

/testenv up

@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor:antd5 labels Jan 28, 2025
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/components/index.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://54.184.81.32:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

/testenv up

Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://18.236.66.245:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://52.12.122.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://35.91.213.164:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

/testenv up

Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://52.13.126.249:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

f8d6741b-edf1-44cd-905a-4597a94fc121_text

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://34.216.170.82:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

/testenv up

Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://35.93.23.171:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Pushing these easy-to-migrate components, hoping to get through a CI run, and that we can fire up an ephemeral environment and make is easier to do a manual review.
@mistercrunch mistercrunch merged commit 1c3ec21 into master Feb 10, 2025
48 checks passed
@mistercrunch mistercrunch deleted the vanilla_migrate branch February 10, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants