Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the legacy dataset editor #31976

Merged
merged 4 commits into from
Jan 24, 2025
Merged

refactor: Removes the legacy dataset editor #31976

merged 4 commits into from
Jan 24, 2025

Conversation

michael-s-molina
Copy link
Member

SUMMARY

As part of the 5.0, this PR executes the 16 - Remove Legacy Datasource Editor proposal.

It also removes some legacy endpoints that were deprecated.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The USE LEGACY DATASOURCE EDITOR option was removed.

320481187-d3d71322-1ad9-486a-8ef7-3ae712786b1d

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@korbit-ai Korbit AI
Copy link

korbit-ai bot commented Jan 23, 2025

Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

@dosubot dosubot bot added frontend:refactor Related to refactoring the frontend risk:breaking-change Issues or PRs that will introduce breaking changes labels Jan 23, 2025
@github-actions github-actions bot added api Related to the REST API packages labels Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.35%. Comparing base (76d897e) to head (0df198f).
Report is 1365 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #31976       +/-   ##
===========================================
+ Coverage   60.48%   83.35%   +22.86%     
===========================================
  Files        1931      544     -1387     
  Lines       76236    38981    -37255     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32492    -13622     
+ Misses      28017     6489    -21528     
+ Partials     2105        0     -2105
Flag Coverage Δ
hive 48.53% <100.00%> (-0.64%) ⬇️
javascript ?
mysql 75.83% <100.00%> (?)
postgres 75.90% <100.00%> (?)
presto 53.07% <100.00%> (-0.74%) ⬇️
python 83.35% <100.00%> (+19.86%) ⬆️
sqlite 75.41% <100.00%> (?)
unit 60.84% <100.00%> (+3.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas requested a review from villebro January 23, 2025 18:26
@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Jan 23, 2025
@michael-s-molina
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@michael-s-molina Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.220.166.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

sadpandajoe
sadpandajoe reviewed Jan 24, 2025
View reviewed changes
superset-frontend/cypress-base/cypress/e2e/sqllab/query.test.ts
@@ -80,7 +80,6 @@ describe('SqlLab query panel', () => {

it.skip('successfully saves a query', () => {
cy.intercept('api/v1/database/**/tables/**').as('getTables');
cy.intercept('savedqueryviewapi/**').as('getSavedQuery');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for housekeeping but probably not needed as the test is being skipped.

rusackas
rusackas approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowner bits (i.e. tests) LGTM! Kill it!!!

@michael-s-molina michael-s-molina merged commit 687f762 into apache:master Jan 24, 2025
52 checks passed
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Jan 24, 2025
tmsjordan pushed a commit to tmsdevelopment/superset that referenced this pull request Feb 1, 2025
@michael-s-molina @tmsjordan
refactor: Removes the legacy dataset editor (apache#31976)
a266012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@sadpandajoe sadpandajoe sadpandajoe approved these changes

@geido geido geido approved these changes

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

@kgabryje kgabryje Awaiting requested review from kgabryje

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
api Related to the REST API frontend:refactor Related to refactoring the frontend packages risk:breaking-change Issues or PRs that will introduce breaking changes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @rusackas @sadpandajoe @geido