Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix/suppress webpack console warnings #31830

Merged
merged 6 commits into from
Jan 14, 2025
Merged

fix: fix/suppress webpack console warnings #31830

merged 6 commits into from
Jan 14, 2025

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 14, 2025

Hit this one today:

superset_node         | WARNING in
./plugins/legacy-preset-chart-deckgl/src/layers/common.tsx 70:13-20
superset_node         | export 'default' (imported as 'd3array') was not
found in 'd3-array' (possible exports: ascending, bisect, bisectLeft,
bisectRight, bisector, cross, descending, deviation, extent, histogram,
max, mean, median, merge, mi
n, pairs, permute, quantile, range, scan, shuffle, sum,
thresholdFreedmanDiaconis, thresholdScott, thresholdSturges,
tickIncrement, tickStep, ticks, transpose, variance, zip)

was introduced here #31761

Then took on fixing the other long-standing warning that's bugging me for a long time

Hit this one today:
```
superset_node         | WARNING in
./plugins/legacy-preset-chart-deckgl/src/layers/common.tsx 70:13-20
superset_node         | export 'default' (imported as 'd3array') was not
found in 'd3-array' (possible exports: ascending, bisect, bisectLeft,
bisectRight, bisector, cross, descending, deviation, extent, histogram,
max, mean, median, merge, mi
n, pairs, permute, quantile, range, scan, shuffle, sum,
thresholdFreedmanDiaconis, thresholdScott, thresholdSturges,
tickIncrement, tickStep, ticks, transpose, variance, zip)
```

Then took on fixing a few more warnings
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Breaking Change in Aggregation Function Support ▹ view
Files scanned
File Path Reviewed
superset-frontend/src/utils/textUtils.ts
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/common.tsx
superset-frontend/webpack.config.js

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Comment on lines +127 to 131
} else if (type in d3functions) {
d3func = d3functions[type];
} else {
d3func = d3array[type];
throw new Error(`Unsupported aggregation type: ${type}`);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking Change in Aggregation Function Support category Functionality

Tell me more
What is the issue?

The change from using d3array[type] to throwing an error for unsupported types may break backward compatibility for any existing charts using aggregation types not included in the new d3functions mapping.

Why this matters

If any dashboards or charts are currently using d3-array functions that aren't explicitly listed in d3functions (like 'bisect', 'group', etc.), they will now fail with an error instead of working as before.

Suggested change ∙ Feature Preview

Consider one of these approaches:

  1. Add all previously supported d3-array functions to d3functions:
const d3functions: Record<string, any> = {
  sum: d3sum,
  min: d3min,
  max: d3max,
  mean: d3mean,
  median: d3median,
  variance: d3variance,
  deviation: d3deviation,
  // Add all other previously supported d3-array functions
};
  1. Or log a warning but provide a fallback behavior:
if (type in d3functions) {
  d3func = d3functions[type];
} else {
  console.warn(`Deprecated: aggregation type '${type}' may not be supported in future versions`);
  d3func = (arr: any[]) => null; // or some other fallback behavior
}
Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.

@rusackas rusackas requested review from rusackas and kgabryje January 14, 2025 19:13
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rusackas rusackas merged commit bbf7586 into master Jan 14, 2025
49 checks passed
@rusackas rusackas deleted the fix_warning branch January 14, 2025 21:59
mistercrunch added a commit that referenced this pull request Jan 14, 2025
Quick fast follow on #31830
parameshnalla added a commit to ajnacloud-ksj/ajna-superset-v1 that referenced this pull request Jan 15, 2025
* chore: bump @ant-design/icons to fix fill-rule console warning (apache#31831)

* fix: fix/suppress webpack console warnings (apache#31830)

* chore: properly import expect from chai in cypress-base/cypress/support/e2e.ts (apache#31846)

* chore(ci): auto delete branches on merge (apache#31847)

* chore: add eslint to pre-commit hooks (apache#31845)

* fix: d3.count doesn't exist (apache#31848)

* feat: Mutate SQL query executed by alerts (apache#31840)

---------

Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Vitor Avila <96086495+Vitor-Avila@users.noreply.github.com>
hainenber pushed a commit to hainenber/superset that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants