-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lang): patch FAB's LocaleView to redirect to previous page #31692
Open
pomegranited
wants to merge
6
commits into
apache:master
Choose a base branch
from
open-craft:jill/patch_flask_locale_redirect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
75a64d0
fix: patch FAB's LocaleView
pomegranited dffbe1f
fix: ensure the referrer is safe before redirecting
pomegranited 3e752db
fix: types and ruff format linting
pomegranited 25814f9
test: adds patch_flask_locale to list of allowed unsecured views
pomegranited 3dc36a2
fix: satisfy codeql
pomegranited 9a5b9c3
tests: adds tests for the patched flask locale view
pomegranited File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
fix: patch FAB's LocaleView
to redirect to the request referrer instead of relying on the session page_history. This change is needed because most of Superset's page views are handled by the frontend, and as such, not stored in the session page_history.
- Loading branch information
commit 75a64d0664ebbcd23f168faefcc4126f3e47b138
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium