Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install uv in docker-bootstrap #31588

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: install uv in docker-bootstrap #31588

merged 2 commits into from
Dec 20, 2024

Conversation

mistercrunch
Copy link
Member

closes #31510

When using docker-compose-non-dev.yml or docker-compose.yml, we mount the docker/ directory in the container. This means we use the logic in the docker-related scripts from whatever branch the user has checked out locally into the container, and. Since uv was introduced recently, older images don't have it, and the script fail.

Here to unblock I'm adding pip install uv to the bootstrap script, which should enable things to run.

Moving forward, it'd be better if docker-compose would NOT mount the docker/ directory, and instead use the docker/ directory from the image. This would ensure that the scripts are always in sync with the image. This is a bit more involved, so I'm going with the simpler fix for now. This also requires having the right entrypoints / CMD instruciton set IN the image. Unclear how whether it's setup ok in older releases, would require pulling each release branch and looking into the entrypoints/CMD instructions in their respective Dockerfiles.

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this bear.

/  \.-"""-./  \
\    -   -    /
 |   o   o   |
 \  .-'''-.  /
  '-\__Y__/-'
     `---`
Files scanned
File Path Reviewed
docker/docker-bootstrap.sh

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Dec 20, 2024
@mistercrunch mistercrunch merged commit fd9c2b3 into master Dec 20, 2024
38 of 39 checks passed
@mistercrunch mistercrunch deleted the fix_compose branch December 20, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose -f docker-compose-image-tag.yml up fails with "uv: command not found"
2 participants