fix: install uv in docker-bootstrap #31588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31510
When using docker-compose-non-dev.yml or docker-compose.yml, we mount the
docker/
directory in the container. This means we use the logic in the docker-related scripts from whatever branch the user has checked out locally into the container, and. Sinceuv
was introduced recently, older images don't have it, and the script fail.Here to unblock I'm adding
pip install uv
to the bootstrap script, which should enable things to run.Moving forward, it'd be better if docker-compose would NOT mount the
docker/
directory, and instead use thedocker/
directory from the image. This would ensure that the scripts are always in sync with the image. This is a bit more involved, so I'm going with the simpler fix for now. This also requires having the right entrypoints / CMD instruciton set IN the image. Unclear how whether it's setup ok in older releases, would require pulling each release branch and looking into the entrypoints/CMD instructions in their respective Dockerfiles.