Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up permissions errors #31363

Closed
wants to merge 3 commits into from
Closed

fix: clean up permissions errors #31363

wants to merge 3 commits into from

Conversation

eschutho
Copy link
Member

SUMMARY

Testing to fix the ephemeral builds

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Dec 10, 2024
@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.219.200.53:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho force-pushed the elizabeth/fix-ephemeral branch from fd74999 to d38e0dd Compare December 10, 2024 01:21
@github-actions github-actions bot removed the github_actions Pull requests that update GitHub Actions code label Dec 10, 2024
@eschutho eschutho changed the title fix: clean up jq string fix: clean up permissions errors Dec 10, 2024
@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://52.33.205.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.244.170.62:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

That first commit worked but not the last one. I need to tweak the env var directory lookup a bit.

@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.244.170.62:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.244.170.62:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho force-pushed the elizabeth/fix-ephemeral branch from 2e2ca32 to d38e0dd Compare December 10, 2024 19:55
@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.220.183.190:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

eschutho commented Dec 10, 2024 •
edited
Loading

I reverted back to the original version which works if we want to merge this. I can iterate on finding a way to use the environment variables so that we don't need to hard code the app path.

mistercrunch
mistercrunch reviewed Dec 10, 2024
View reviewed changes
Dockerfile
Comment on lines +124 to +125
&& chown -R superset:superset /app \
&& chmod -R 775 /app \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if these 2 commands would be belong right before the USER superset command, and if we do so we might be able to simplify the COPY commands and other chown/chmod throughout the Dockerfile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31385

@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.209.140.91:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

closing in favor of #31385

@eschutho eschutho closed this Dec 10, 2024
@rusackas rusackas deleted the elizabeth/fix-ephemeral branch December 10, 2024 23:39
@eschutho eschutho restored the elizabeth/fix-ephemeral branch December 11, 2024 00:06
@eschutho eschutho reopened this Dec 11, 2024
@eschutho eschutho force-pushed the elizabeth/fix-ephemeral branch from 9a5e1fd to 8776791 Compare December 11, 2024 00:09
@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://44.243.18.92:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.149.181.65:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro

@geido geido Awaiting requested review from geido

@rusackas rusackas Awaiting requested review from rusackas

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@nytai nytai Awaiting requested review from nytai

@craig-rueda craig-rueda Awaiting requested review from craig-rueda

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
preset-io size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschutho @mistercrunch