Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(moment): Replace Moment.js with DayJs #31310

Merged
merged 22 commits into from
Dec 23, 2024
Merged

refactor(moment): Replace Moment.js with DayJs #31310

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ba7a325
refactor(moment): Replace Moment.js with DayJs
msyavuz Dec 5, 2024
ded1285
fix(package): sync package.json and tests
msyavuz Dec 6, 2024
63d7c02
refactor(moment): refactor moment out of components
msyavuz Dec 16, 2024
17d0041
refactor(dayjs): re-add moment and migrate components
msyavuz Dec 17, 2024
8eb99d3
refactor(dayjs): migrate some components
msyavuz Dec 17, 2024
f556d9c
chore(moment): add comment and change moment to dayjs
msyavuz Dec 17, 2024
8572277
refactor(dayjs): centralize dayjs extensions
msyavuz Dec 17, 2024
fd2f451
chore(dayjs): add test for extensions and change package.jsons
msyavuz Dec 17, 2024
4a55d06
fix(type): type from dayjs instead
msyavuz Dec 17, 2024
9c8eca1
Merge branch 'master' into msyavuz/momentjs-to-dayjs
msyavuz Dec 17, 2024
6cbac28
fix(test): only wait for load if its loading
msyavuz Dec 18, 2024
e9fcacd
test(AlertReportModal): use events directly instead?
msyavuz Dec 18, 2024
a035c87
test(AlertReportModal): fix the test
msyavuz Dec 18, 2024
af97ee0
refactor(pluigin-echarts): move to dayjs
msyavuz Dec 18, 2024
5a0862a
chore: remove unused waitfor
msyavuz Dec 18, 2024
a3e10bf
feat(moment): remove timezone-support, migrate handlebars to dayjs
msyavuz Dec 18, 2024
638599f
chore(timezone-support): remove usages
msyavuz Dec 18, 2024
854a66a
refactor(legacy-plugins): migrate to dayjs
msyavuz Dec 18, 2024
972bf08
fix(timezoneselector): use map instead of array and remove unneccessa…
msyavuz Dec 19, 2024
58a7355
refactor(alert report modal): remove loading check
msyavuz Dec 19, 2024
f60a221
chore(alert report modal): remove unused import
msyavuz Dec 19, 2024
03ab506
chore(types): add some types instead of any
msyavuz Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(type): type from dayjs instead
  • Loading branch information
@msyavuz
msyavuz committed Dec 17, 2024
commit 4a55d066692e8a19411efb4ce75e788951d100c3
3 changes: 2 additions & 1 deletion superset-frontend/src/components/LastUpdated/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
import { extendedDayjs } from 'src/utils/dates';
import { t, styled } from '@superset-ui/core';
import Icons from 'src/components/Icons';
import dayjs from 'dayjs';

const REFRESH_INTERVAL = 60000; // every minute

Expand Down Expand Up @@ -62,7 +63,7 @@ export const LastUpdated: FunctionComponent<LastUpdatedProps> = ({
updatedAt,
update,
}) => {
const [timeSince, setTimeSince] = useState<extendedDayjs.Dayjs>(
const [timeSince, setTimeSince] = useState<dayjs.Dayjs>(
extendedDayjs(updatedAt),
);

Expand Down