Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(🦾): bump python et-xmlfile 1.1.0 -> 2.0.0 & remove pyhive[hive] from requirements/development.in #31040

Merged
merged 10 commits into from
Nov 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the python "et-xmlfile" library version from 1.1.0 to 2.0.0.

Generated by @supersetbot 🦾

🌳:

et-xmlfile
  openpyxl
    dataflows-tabulator
      tableschema
        apache-superset

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 24, 2024
@mistercrunch mistercrunch changed the title chore(🦾): bump python et-xmlfile 1.1.0 -> 2.0.0 chore(🦾): bump python et-xmlfile 1.1.0 -> 2.0.0 & remove pyhive[hive] from requirements/development.in Nov 24, 2024
@mistercrunch
Copy link
Member

mistercrunch commented Nov 24, 2024

Debugging this I hit various issues related to pip-compile-multi being non-deterministic and installing pyhive[presto] at times (no issue) and pyhive[hive] at others, leading to a rabbit hole around the complex/old C-libs that Hive requires. Here I'm making the call that supporting pyhive[hive] in our CI is a significant burden (sasl, thrift, ...) which shouldn't be our problem as core maintainers. If people use hive, they can install the pyhive[hive] lib, its dependencies and run the test suite in that context.

For now I'm keeping pyhive[presto] since it's not antiquated and uses a common REST interface, doesn't require a bunch of libs to be supported/tested as part of our suite.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 24, 2024
@mistercrunch mistercrunch merged commit c5f6cc6 into master Nov 24, 2024
33 of 34 checks passed
@mistercrunch mistercrunch deleted the supersetbot-bump-et-xmlfile branch November 24, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/L supersetbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants