Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sunburst): Added some options to adjust Sunburst chart view: innerRadius, outerRadius, donut, showNulls #30987

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bwa84
Copy link

@bwa84 bwa84 commented Nov 20, 2024

SUMMARY

Added some options to adjust Sunburst chart:

  • showNulls: allow to show / hide slices with null value
  • donut: allow to switch between donut / circle view (donut was fixed before)
  • innerRadius: allow to adjust inner radius when donut is checked
  • outerRadius: allow to adjust outer radius

AFTER SCREENSHOT

obraz

TESTING INSTRUCTIONS

  • create or edit sunburst chart
  • switch to Customize control page
  • play with "Donut", "Inner Radius", "Outer Radius" & "Show values" options

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:sunburst Related to the Sunburst chart label Nov 20, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/L viz:charts:sunburst Related to the Sunburst chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant