Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Exclude edit param in async screenshot #30962

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

geido
Copy link
Member

@geido geido commented Nov 18, 2024

SUMMARY

This PR #30675 introduced a way to pass urlParams to the async dashboard screenshot generation endpoint. However, edit was an acceptable value which caused the system to take a screenshot in edit mode of a newly created dashboard. This PR fixes that.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Create a new dashboard
  2. Download the dashboard screenshot as PDF
  3. The screenshot should not be showing the dashboard in edit mode

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added dashboard:editmode Related to te Dashboard edit mode dashboard:export Related to exporting dashboards labels Nov 18, 2024
Copy link
Contributor

@Vitor-Avila Vitor-Avila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this! 🙏

@geido geido merged commit 1b63b8f into master Nov 18, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:editmode Related to te Dashboard edit mode dashboard:export Related to exporting dashboards size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants