fix(helm): use submodule on helm release action #30924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#28498 introduced a regression that broke the Helm chart release workflow, which can be seen on the workflow summary here: https://github.com/apache/superset/actions/workflows/superset-helm-release.yml. This is due to a limitation on using external actions, which can be worked around using submodules. See #12709 which introduced the
chart-releaser-action
submodule among others.This PR:
chart-releaser-action
tov1.6.0
which is the latest version and supports themark_as_latest
property.0.13.1
to retrigger the helm deploy workflow on merge. I considered adding the helm workflow file to thepath
to retrigger this every time there's a change to the workflow config. However, in the end I decided not to, as it may be confusing if the workflow is triggered when there are no changes to the chart.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION