Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): use submodule on helm release action #30924

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

villebro
Copy link
Member

@villebro villebro commented Nov 14, 2024

SUMMARY

#28498 introduced a regression that broke the Helm chart release workflow, which can be seen on the workflow summary here: https://github.com/apache/superset/actions/workflows/superset-helm-release.yml. This is due to a limitation on using external actions, which can be worked around using submodules. See #12709 which introduced the chart-releaser-action submodule among others.

This PR:

  • Reverts the change in chore: Don't mark Helm releases as latest #28498 so we continue using the submodule.
  • Bumps the SHA on the chart-releaser-action to v1.6.0 which is the latest version and supports the mark_as_latest property.
  • Bumps the Helm chart version to 0.13.1 to retrigger the helm deploy workflow on merge. I considered adding the helm workflow file to the path to retrigger this every time there's a change to the workflow config. However, in the end I decided not to, as it may be confusing if the workflow is triggered when there are no changes to the chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Nov 14, 2024
@dosubot dosubot bot added the deploy:helm label Nov 14, 2024
@villebro villebro changed the title Villebro/helm releaser 1.6.0 fix(helm): use submodule on helm release action Nov 14, 2024
@villebro villebro merged commit a3e89cb into apache:master Nov 14, 2024
57 of 61 checks passed
@villebro villebro deleted the villebro/helm-releaser-1.6.0 branch November 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy:helm github_actions Pull requests that update GitHub Actions code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants