Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the tab order #30888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

US579
Copy link
Contributor

@US579 US579 commented Nov 10, 2024

SUMMARY

When export all tabs to a PDF in report & alert, user noticed that the all tabs export doesn't seem to export the tabs in any specific order (our report with 3 tabs exported with tab 2, then 3, then 1 in the PDF)

reference: #30694 (comment)

Context

The exported tabs are now ordered based on the sequence of anchors under the all_tabs field from the tabs endpoint response. This enhancement aligns the export order with the order displayed on the dashboard.

BEFORE PDF

before.pdf

AFTER PDF

after.pdf

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Nov 10, 2024
@dosubot dosubot bot added alert-reports Namespace | Anything related to the Alert & Reports feature dashboard:tab Related to the usage of tabs in the Dashboard labels Nov 10, 2024
@US579
Copy link
Contributor Author

US579 commented Nov 10, 2024

FYI @yousoph

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (76d897e) to head (48dc387).
Report is 955 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30888       +/-   ##
===========================================
+ Coverage   60.48%   83.92%   +23.43%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38931    -37305     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32673    -13441     
+ Misses      28017     6258    -21759     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.85% <12.50%> (-0.31%) ⬇️
javascript ?
mysql 76.79% <100.00%> (?)
postgres 76.88% <100.00%> (?)
presto 53.33% <12.50%> (-0.47%) ⬇️
python 83.92% <100.00%> (+20.43%) ⬆️
sqlite 76.34% <100.00%> (?)
unit 60.87% <12.50%> (+3.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

LGTM, but @eschutho might be better poised to actually test this before approving/merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature api Related to the REST API dashboard:tab Related to the usage of tabs in the Dashboard size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants