Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(empty dashboards): Allow downloading a screenshot of an empty dashboard #30767

Merged
merged 7 commits into from
Nov 13, 2024
Merged

fix(empty dashboards): Allow downloading a screenshot of an empty dashboard #30767

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11fdfca
fix(empty dashboards): check for chart-container first
msyavuz Oct 31, 2024
3c80d79
refactor(webdriver): try after failing for charts to wait for load
msyavuz Nov 4, 2024
3ec44ad
fix(call): refactor the call for tuple
msyavuz Nov 4, 2024
326b8bd
Merge branch 'master' into msyavuz/fix/empty-dashboard-screenshot
msyavuz Nov 7, 2024
a37fdbb
Update superset/utils/webdriver.py
geido Nov 13, 2024
ec238c4
Update superset/utils/webdriver.py
geido Nov 13, 2024
38032e5
Update superset/utils/webdriver.py
geido Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions superset/utils/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,11 +379,19 @@ def get_screenshot(self, url: str, element_name: str, user: User) -> bytes | Non
)
)
except TimeoutException:
logger.exception(
"Selenium timed out waiting for chart containers to draw at url %s",
url,
)
raise
# Fallback to allow a screenshot of an empty dashboard
try:
WebDriverWait(driver, 0).until(
EC.visibility_of_all_elements_located(
(By.CLASS_NAME, "grid-container")
)
)
except:
logger.exception(
"Selenium timed out waiting for dashboard to draw at url %s",
url,
)
raise

try:
# charts took too long to load
Expand Down
Loading