Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🌐 Translations added to ES .po file #30759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcardenas3
Copy link

SUMMARY

Update spanish translations for time range filter options

TESTING INSTRUCTIONS

Change language settings to Spanish and check translations via GUI or manually check them in messages.po file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

ADDITIONAL INFORMATION

  • Has associated issue:

  • Required feature flags:

  • Changes UI

  • Includes DB Migration (follow approval process in SIP-59)

    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API

  • Removes existing feature or API

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:spanish Translation related to Spanish language labels Oct 30, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@jcardenas3 jcardenas3 changed the title chore: 🌐 Translations (not all) added to ES .po … chore: 🌐 Translations added to ES .po file Oct 30, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (76d897e) to head (3eeb4ea).
Report is 909 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30759       +/-   ##
===========================================
+ Coverage   60.48%   83.94%   +23.45%     
===========================================
  Files        1931      535     -1396     
  Lines       76236    38827    -37409     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32592    -13522     
+ Misses      28017     6235    -21782     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.89% <ø> (-0.27%) ⬇️
javascript ?
mysql 76.78% <ø> (?)
postgres 76.90% <ø> (?)
presto 53.38% <ø> (-0.42%) ⬇️
python 83.94% <ø> (+20.45%) ⬆️
sqlite 76.36% <ø> (?)
unit 60.87% <ø> (+3.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:spanish Translation related to Spanish language i18n Namespace | Anything related to localization size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant