-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dashboard): Retain colors when color scheme not set #30646
base: master
Are you sure you want to change the base?
Conversation
Upvote for this. This problem is annoying. |
f65b57b
to
23dbe5e
Compare
23dbe5e
to
7e23659
Compare
OMG thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing, LGTM!
I will try to tackle an issue for which after deleting a color scheme from a Dashboard and then editing the Chart from the Dashboard, Explore won't allow to customize the color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0cc680f
to
b9aeee8
Compare
…o/fix/color-consistency-race-conditions
…o/fix/color-consistency-race-conditions
c440bc6
to
6421f4b
Compare
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/color/CategoricalColorNamespace.ts
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/color/LabelsColorMapSingleton.ts
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
/testenv up |
@kgabryje Ephemeral environment spinning up at http://35.93.185.64:8080. Credentials are |
SUMMARY
This PR does the following:
BEFORE
Color.Consistency.Test.mp4
AFTER
Color.Consistency.Test.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION