Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): set chart appVersion to 4.0.2 #30579

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(helm): set chart appVersion to 4.0.2 #30579

wants to merge 1 commit into from

Conversation

alecodev
Copy link

SUMMARY

Fixed Helm version to match latest release

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the deploy:helm label Oct 11, 2024
github-actions[bot]
github-actions bot reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

Ruh roh... thanks for the approval @dpgaspar but it seems we didn't merge this fast enough! @alecodev could you rebase/update the PR, and we'll try to snipe the merge button a little faster this time?

villebro
villebro approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebasing and setting the correct new chart version number (patch bump). FYI we're planning on moving to latest tag after 4.1.0 release for latest stable version, so these types of bump chores won't be needed in the future.

@rusackas
Copy link
Member

Moving this to draft mode, hopeful that @alecodev comes back to touch it up and mark it as "ready for review" again :)

@rusackas rusackas marked this pull request as draft November 11, 2024 17:06
@MattpaulKing
Copy link

watching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@villebro villebro villebro approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@nytai nytai Awaiting requested review from nytai nytai will be requested when the pull request is marked ready for review nytai is a code owner

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina michael-s-molina will be requested when the pull request is marked ready for review michael-s-molina is a code owner

Assignees
No one assigned
Labels
deploy:helm review:draft size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alecodev @rusackas @MattpaulKing @dpgaspar @villebro @sadpandajoe