Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no select following review #30498

Closed
wants to merge 26 commits into from
Closed

Update no select following review #30498

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a15cc8c
disable data selection from results table
MialLewis Jul 17, 2024
2a58dd7
disable selection from chart table
MialLewis Jul 17, 2024
62f5b00
disable pivot chart select
MialLewis Jul 17, 2024
ca17002
add user select to permissions model
MialLewis Jul 22, 2024
06a44d8
change perms to can_export_csv
MialLewis Jul 22, 2024
71018c8
pass dataSelectionMode prop to plugin
MialLewis Jul 29, 2024
703e7ef
remove unneeded prop
MialLewis Jul 29, 2024
fafe95b
get permissions from role TableChart
MialLewis Jul 30, 2024
27d22d1
add user permissions to pivot table
MialLewis Jul 31, 2024
6b35723
apply linter and fix compiler errors
MialLewis Jul 31, 2024
6156e5f
update permissions to inline with previous features
MialLewis Jul 31, 2024
4b16a68
fix filterable table test
MialLewis Aug 2, 2024
1f7ff0e
Merge pull request #1 from MialLewis/disable_data_selection_konza
bcook-konza Aug 2, 2024
b7a785d
move access to redux state outside of filterable table comp
MialLewis Sep 9, 2024
0ef5633
move state query to DashboardBuilder
MialLewis Sep 9, 2024
5d66273
revert redundant changes to filt table test
MialLewis Sep 9, 2024
bb67c04
ammend transform props test
MialLewis Sep 9, 2024
fa24412
remove unneeded import
MialLewis Sep 9, 2024
0df6fef
access state from explorechartpanel
MialLewis Sep 10, 2024
45732ad
correct chart props
MialLewis Sep 10, 2024
fef1e90
remove canExportData from DashboardBuilder and component, pass in fro…
MialLewis Sep 11, 2024
38215d2
run prettier
MialLewis Sep 11, 2024
7e2e1fa
remove unneeded test change
MialLewis Sep 11, 2024
8a31bf2
remove redundant filt table test var
MialLewis Sep 11, 2024
7d7f5f7
update buildQuery test with DataSelectionMode
MialLewis Sep 24, 2024
aa02fc6
Merge branch 'master' into update_no_select_following_review
MialLewis Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unneeded prop
  • Loading branch information
@MialLewis
MialLewis committed Jul 31, 2024
commit 703e7efcc0ba2a3c8963a5f5d6cf5e49ac46e6b6
2 changes: 0 additions & 2 deletions superset-frontend/packages/superset-ui-core/src/chart/components/SuperChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ export type Props = Omit<SuperChartCoreProps, 'chartProps'> &
* Determines is the context menu related to the chart is open
*/
inContextMenu?: boolean;
/** Prop that controls user selection of chart data */
dataSelectionMode?: string;
};

type PropsWithDefault = Props & Readonly<typeof defaultProps>;
Expand Down