fix(explore): don't discard controls on deprecated #30447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, if a column or metric name changes in Explore, any previously selected control items disappear. This can lead to confusion during debugging, as the control items mentioned in the error message are not actually displayed.
This commit modifies explore to display a warning message in such cases, allowing the user to manually delete and modify the control items.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--warning-markdown.mov
After:
after--warning-markdown.mov
TESTING INSTRUCTIONS
Create a chart with a dataset
Select a column / a metric in the control and then save
Edit the dataset and then change the name of the above selected column/metric
Revisit the chart and then see the error message
ADDITIONAL INFORMATION