fix: cypress on master doesn't work because of --parallel flag #30430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was really confused as to why my PR worked in my PR but not on the main branch after merging, and found out why... we're running a slightly different command on master where we want to use the Cypress dashboard feature (gets expensive quick on PRs, but is manageable on the main branch). Since my change went towards running a single spec at a time, the --parallel flag doesn't make sense and was erroring out. I can't really test this easily outside master, so here we go. I don't think anyone uses the Cypress dashboard tbh
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
villebro
approved these changes
Sep 30, 2024
mistercrunch
added a commit
that referenced
this pull request
Sep 30, 2024
Following up on a series of PRs to try and fix cypress run, latest being this one #30430. Here I'm working a bit in the dark since the logic on `master` in CI is slightly different from the logic in PRs. On my latest try, I had an error related to a combination of retries in the context where the dashboard is used. Issue was around the group id's not being unique. Here I'm working around it by adding the attempt number to the group's id, which should fix it. At this point I'm beyond annoyed with Cypress. Last try before I shut down using the dashboard feature (a paying service we don't really get much if any benefit from) at all.
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was really confused as to why my PR worked in my PR but not on the main branch after merging, and found out why... we're running a slightly different command on master where we want to use the Cypress dashboard feature (gets expensive quick on PRs, but is manageable on the main branch). Since my change went towards running a single spec at a time, the --parallel flag doesn't make sense and was erroring out.
I can't really test this easily outside master, so here we go.
I don't think anyone uses the Cypress dashboard tbh
tested here with
gh workflow run superset-e2e.yml --ref no_dash --field use_dashboard=true --field ref=no_dash:https://github.com/apache/superset/actions/runs/11098683939