-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Histogram chart not able to use decimal datatype column #30416
fix: Histogram chart not able to use decimal datatype column #30416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30416 +/- ##
===========================================
+ Coverage 60.48% 70.77% +10.28%
===========================================
Files 1931 1981 +50
Lines 76236 79797 +3561
Branches 8568 9089 +521
===========================================
+ Hits 46114 56478 +10364
+ Misses 28017 21097 -6920
- Partials 2105 2222 +117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to raise a warning that non-numeric data has been excluded when records are coerced to NaN?
Good point @fisjac. I changed the logic to let users handle non-numeric values as they might want to fix their datasets or add filters to remove these values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 4834390)
SUMMARY
Fixes #30301 by making the Histogram chart more resilient when handling non-numeric columns or numeric columns with non-numeric values.
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION