Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Histogram chart not able to use decimal datatype column #30416

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Sep 27, 2024

SUMMARY

Fixes #30301 by making the Histogram chart more resilient when handling non-numeric columns or numeric columns with non-numeric values.

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:histogram Related to the Histogram chart label Sep 27, 2024
@michael-s-molina michael-s-molina added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.77%. Comparing base (76d897e) to head (355df1c).
Report is 1094 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30416       +/-   ##
===========================================
+ Coverage   60.48%   70.77%   +10.28%     
===========================================
  Files        1931     1981       +50     
  Lines       76236    79797     +3561     
  Branches     8568     9089      +521     
===========================================
+ Hits        46114    56478    +10364     
+ Misses      28017    21097     -6920     
- Partials     2105     2222      +117     
Flag Coverage Δ
hive 48.98% <20.00%> (-0.19%) ⬇️
javascript 58.51% <ø> (+0.79%) ⬆️
mysql 76.83% <20.00%> (?)
postgres 76.93% <20.00%> (?)
presto 53.48% <20.00%> (-0.33%) ⬇️
python 83.91% <100.00%> (+20.42%) ⬆️
sqlite 76.38% <20.00%> (?)
unit 60.67% <100.00%> (+3.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fisjac fisjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to raise a warning that non-numeric data has been excluded when records are coerced to NaN?

@michael-s-molina
Copy link
Member Author

Does it make sense to raise a warning that non-numeric data has been excluded when records are coerced to NaN?

Good point @fisjac. I changed the logic to let users handle non-numeric values as they might want to fix their datasets or add filters to remove these values.

Copy link
Contributor

@fisjac fisjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 4834390 into apache:master Sep 30, 2024
37 checks passed
sadpandajoe pushed a commit that referenced this pull request Sep 30, 2024
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch viz:charts:histogram Related to the Histogram chart 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram chart not able to use decimal datatype column
3 participants