-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): Missing markarea component broke annotations in echarts #30348
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
requested review from
eschutho,
Antonio-RiveroMartnez,
sadpandajoe and
geido
September 20, 2024 13:57
dosubot
bot
added
explore:annotation
Related to annotations in Explore
viz:charts:echarts
Related to Echarts
labels
Sep 20, 2024
/testenv up |
geido
approved these changes
Sep 20, 2024
@kgabryje Ephemeral environment spinning up at http://52.25.177.79:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
sadpandajoe
added
the
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
label
Sep 20, 2024
3 tasks
3 tasks
sadpandajoe
removed
the
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
label
Sep 23, 2024
sadpandajoe
added
the
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
label
Oct 23, 2024
3 tasks
3 tasks
github-actions
bot
added
🍒 4.1.0
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
explore:annotation
Related to annotations in Explore
plugins
size/XS
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
viz:charts:echarts
Related to Echarts
🍒 4.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Recent Echarts bundle size optimization PR didn't register
MarkLineComponent
andMarkAreaComponent
fromecharts/components
package, which broke annotations.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
year
as x-axis,sum__SP_POP_TOTL
as metricADDITIONAL INFORMATION