Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Missing markarea component broke annotations in echarts #30348

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Sep 20, 2024

SUMMARY

Recent Echarts bundle size optimization PR didn't register MarkLineComponent and MarkAreaComponent from echarts/components package, which broke annotations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

  1. Create an annotation layer
    • date 2000-01-01 -> 2002-01-01
  2. Save
  3. Create an Echarts line chart with wb_health_population dataset
  4. Use year as x-axis, sum__SP_POP_TOTL as metric
  5. Add the annotation
    • Show labe = checked
    • annotation layer type = interval
    • annotation source = Superset annotation
    • annotation layer = your annotation layer
    • hit ok
  6. click update chart
  7. Verify that the annotation is visible
  8. Do the same for annotation layer type = Event

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added explore:annotation Related to annotations in Explore viz:charts:echarts Related to Echarts labels Sep 20, 2024
@kgabryje
Copy link
Member Author

/testenv up

Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://52.25.177.79:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@kgabryje kgabryje merged commit 038ef32 into apache:master Sep 20, 2024
35 of 36 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 20, 2024
@sadpandajoe sadpandajoe linked an issue Sep 20, 2024 that may be closed by this pull request
3 tasks
sadpandajoe pushed a commit that referenced this pull request Sep 23, 2024
@sadpandajoe sadpandajoe removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 23, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 23, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 23, 2024
@sadpandajoe sadpandajoe linked an issue Oct 23, 2024 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:annotation Related to annotations in Explore plugins size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch viz:charts:echarts Related to Echarts 🍒 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation layer of type Event not showing Interval annotations on charts broken in master
3 participants