Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Invalid owner's name displayed after updates #30272

Merged

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Sep 13, 2024

Fixes #30259

SUMMARY

The action DASHBOARD_INFO_UPDATED changes the first_name and last_name properties of the owner to a full_name property [#17570].
Screenshot 2024-09-13 at 1 53 01 PM

However, the display change logic for the full_name property is only applied in the property modal, resulting in an error where other code referencing the owner outputs undefined.
To resolve this issue, the same Owner type and display getter function have been applied in the affected code.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--owner-name-hotfix.mov

After:

after--owner-name-hotfix.mov

TESTING INSTRUCTIONS

  1. Update the dashboard owners
  2. Check the metadata bar owners

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard Namespace | Anything related to the Dashboard label Sep 13, 2024
@justinpark justinpark force-pushed the hotfix--invalid-owner-label-after-update branch from 8bb8bc9 to eaa4238 Compare September 17, 2024 17:32
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 17, 2024
@justinpark justinpark merged commit 2f0c994 into apache:master Sep 17, 2024
35 checks passed
sadpandajoe pushed a commit that referenced this pull request Sep 18, 2024
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard Namespace | Anything related to the Dashboard size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard owners is not updating correctly in the metadata tooltip
3 participants