fix(sqllab): race condition when updating same cursor position #30141
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In certain cases, a race condition was observed where the cursor position in the Redux state and the cursor position in the ACE editor would repeatedly update each other.
This commit modifies the behavior to update the position only when the current cursor position differs from the value in the Redux state, in order to prevent this issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
�
Before:
before--race-cursorposition-condition.mov
After:
No maximum update depth exceeded error thrown
TESTING INSTRUCTIONS
locally
ADDITIONAL INFORMATION