Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump reselect from 4.1.8 to 5.1.1 in /superset-frontend/packages/superset-ui-core #30092

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2024

Bumps reselect from 4.1.8 to 5.1.1.

Release notes

Sourced from reselect's releases.

v5.1.1

This patch release fixes behavior of resultEqualityCheck in weakMapMemoize, fixes the case of lruMemoize being given a maxSize less than 1, and tweaks the internal implementation of lruMemoize. (We've also updated our general build tooling.)

Changelog

Bug fixes

Previously, providing the resultEqualityCheck option to weakMapMemoize resulted in it being called with empty objects as part of the initialization / dev check process. That could be an issue if your comparison function expected different values. We've updated the logic to avoid that, as well as improving a couple other perf aspects.

Previously, passing a maxSize < 1 to lruMemoize would result in it creating a larger cache. That's now fixed.

lruMemoize now uses a symbol for its NOT_FOUND value instead of a string.

What's Changed

Full Changelog: reduxjs/reselect@v5.1.0...v5.1.1

v5.1.0

This minor release:

  • Adds a new createSelector.withTypes<RootState>() and createStructuredSelector.withTypes<RootState>() API
  • Deprecates the TypedStructuredSelectorCreator type introduced in 5.0
  • Aims to reduce false positives in identityFunctionCheck by only running if the output selector is passed one argument
  • Fixes a bug with weakMapMemoize's resultEqualityCheck when used with a primitive result.

withTypes

Most commonly, selectors will accept the root state of a Redux store as their first argument. withTypes allows you to specify what that first argument will be ahead of creating the selector, meaning it doesn't have to be specified.

// previously
export const selectPostById = createSelector(
  [
    (state: RootState) => state.posts.entities,
    (state: RootState, id: number) => id,
  ],
  (entities, id) => entities[id],
);
// now
export const createAppSelector = createSelector.withTypes<RootState>();
export const selectPostById = createAppSelector(
[(state) => state.posts.entities, (state, id: number) => id],
(entities, id) => entities[id],
);
</tr></table>

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@rusackas
Copy link
Member

rusackas commented Sep 6, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/reselect-5.1.1 branch from 99586b7 to ec6fb52 Compare September 6, 2024 15:52
Bumps [reselect](https://github.com/reduxjs/reselect) from 4.1.8 to 5.1.1.
- [Release notes](https://github.com/reduxjs/reselect/releases)
- [Changelog](https://github.com/reduxjs/reselect/blob/master/CHANGELOG.md)
- [Commits](reduxjs/reselect@v4.1.8...v5.1.1)

---
updated-dependencies:
- dependency-name: reselect
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/reselect-5.1.1 branch from ec6fb52 to 05849a0 Compare September 9, 2024 16:28
@rusackas rusackas added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Sep 9, 2024
@rusackas
Copy link
Member

rusackas commented Sep 9, 2024

There were some breaking changes, but they don't seem to affect us.

@rusackas
Copy link
Member

rusackas commented Sep 9, 2024

Unit tests need love, it seems. I re-ran them a couple times.

@rusackas rusackas added dependencies:needs-work and removed merge-if-green If approved and tests are green, please go ahead and merge it for me labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant