-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): skip extremely flaky gaq test #30072
chore(tests): skip extremely flaky gaq test #30072
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30072 +/- ##
===========================================
+ Coverage 60.48% 70.53% +10.04%
===========================================
Files 1931 1975 +44
Lines 76236 79425 +3189
Branches 8568 9043 +475
===========================================
+ Hits 46114 56024 +9910
+ Misses 28017 21175 -6842
- Partials 2105 2226 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding sleeps aren't a good solution to getting a flaky test working so I agree let's just disable it until we have a real solution, it seems like it's causing more harm than good.
Given how much you're struggling with the cypress tests as well I'd disable that one while you're here too.
718b793
to
dfa0d2a
Compare
Makes sense, converted to draft, feel free to reflag for review if you want to push this one through |
dfa0d2a
to
3d7ff5d
Compare
SUMMARY
The
test_chart_data_async
has been disabled, then re-enabled in the hopes that the new sleeps would fix it. This was not the case, and it's causing a lot of headache for getting CI green on PRs. I'm disabling it for now, and these will all likely be rewritten soon as part of SIP-134.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION