-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(capitalization): Capitalizing a button. #29867
Conversation
/testenv up |
@yousoph asked for an env to test the capitalization |
@rusackas I think @mistercrunch's test env command didn't work, can you try to do it? 🙏🏻 |
Hah, I merged it too quickly, sorry... not sure why ephemerals aren't working. I did test it though, as seen in the screenshots. There is one remaining inconsistency, but it seemed relatively minor. It asks in one modal "Delete Alert?" or "Delete Report?" now. I can just make it so that these strings aren't reused variables, and just put them in the correct capitalization in the places they go. |
Ha, it's on you now @rusackas 🤠 |
Maybe we're OK, depending on how our capitalization lawyers interpret this:
|
(cherry picked from commit 052b38b)
SUMMARY
Capitalizing the
+ Alert
and+ Report
buttons.Before:
After:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION