Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(controls): Migrate MetricDefinitionValue.test to RTL #29845

Merged
merged 1 commit into from
Aug 2, 2024
Merged

refactor(controls): Migrate MetricDefinitionValue.test to RTL #29845

merged 1 commit into from
Aug 2, 2024

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented Aug 2, 2024

SUMMARY

Convert tests to RTL

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Run tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the explore Namespace | Anything related to Explore label Aug 2, 2024
@rtexelm rtexelm merged commit 27c08d0 into apache:master Aug 2, 2024
36 of 37 checks passed
WanjohiWanjohi pushed a commit to IDinsight/surveystream_superset_source that referenced this pull request Aug 6, 2024
@rtexelm @WanjohiWanjohi
refactor(controls): Migrate MetricDefinitionValue.test to RTL (apache…
58df3d3 
…#29845)
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 13, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@rtexelm @sadpandajoe
refactor(controls): Migrate MetricDefinitionValue.test to RTL (#29845)
aaecec2 
(cherry picked from commit 27c08d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
explore Namespace | Anything related to Explore size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtexelm @mistercrunch @sadpandajoe