-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: frontend webpack proxy support zstd encoding #29822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this! Looks like it's working fine. It might need a rebase to pick up a CI fix from another PR, and it looks like it has some linting issues, which can be resolved with our pre-commit hooks. Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:
Alternatively it is possible to run pre-commit by running pre-commit manually:
|
Pushed a commit to (hopefully) fix the linting issue |
Not sure why Docker is failing here (cc @mistercrunch ) Good news is, When I go to port 8088, however, it doesn't look like the webpack build happened, and the frontend isn't present. |
@dosubot what is zstd and why do we need it? |
I think we're hitting memory limits in GHA, it seems we've been right against the edge on it and I'm afraid PRs are going to fail randomly more and more until we address it. I discussed it here #29771 (comment), and I'm a bit at a loss for a solution. |
a3430f4
to
f62a3a4
Compare
Docker failed This looks like we needs to install zstd in System. The npm package |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION