Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing incomplete string escaping. #29772

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: Fixing incomplete string escaping. #29772

merged 1 commit into from
Jul 30, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Follows this advice: https://github.com/apache/superset/security/code-scanning/10

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added explore Namespace | Anything related to Explore javascript Dependabot - Pull requests that update Javascript code labels Jul 29, 2024
@rusackas rusackas changed the title Fix(js): Fixing incomplete string escaping. fix: Fixing incomplete string escaping. Jul 29, 2024
@rusackas rusackas merged commit 2bce20f into master Jul 30, 2024
37 of 40 checks passed
@rusackas rusackas deleted the better-replace branch July 30, 2024 22:36
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Aug 1, 2024
@rusackas @sadpandajoe
fix: Fixing incomplete string escaping. (apache#29772)
b9aace4 
(cherry picked from commit 2bce20f)
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 1, 2024
@sadpandajoe
Copy link
Member

@supersetbot unlabel 4.1

@github-actions github-actions bot removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 1, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@rusackas @sadpandajoe
fix: Fixing incomplete string escaping. (#29772)
0d0b430 
(cherry picked from commit 2bce20f)
michael-s-molina pushed a commit that referenced this pull request Nov 19, 2024
@rusackas @michael-s-molina
fix: Fixing incomplete string escaping. (#29772)
bde69e4 
(cherry picked from commit 2bce20f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@sadpandajoe sadpandajoe sadpandajoe approved these changes

Assignees
No one assigned
Labels
explore Namespace | Anything related to Explore javascript Dependabot - Pull requests that update Javascript code preset-io size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusackas @sadpandajoe @michael-s-molina