Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use default custom time range time without timezone #29669

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: Use default custom time range time without timezone #29669

merged 1 commit into from
Jul 23, 2024
+12 −12

Conversation

kgabryje
Copy link
Member

SUMMARY

In custom time range filter, in specific mode, the default time would show UTC midnight adjusted to user's current timezone. This PR fixes that behaviour by using the time without timezone.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2024-07-23 at 15 04 59

After:

Screenshot 2024-07-23 at 15 05 58

TESTING INSTRUCTIONS

  1. Open explore and add a time range filter
  2. Open time range filter edit modal
  3. Select Custom -> Specific Date/Time
  4. Verify that the default value is the current day and the time is 00:00:00

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the explore:time Related to the time filters in Explore label Jul 23, 2024
Antonio-RiveroMartnez
Antonio-RiveroMartnez approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kgabryje kgabryje merged commit cd713a2 into apache:master Jul 23, 2024
34 of 36 checks passed
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Jul 23, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@kgabryje @eschutho
fix: Use default custom time range time without timezone (#29669)
f5b1263
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
@sadpandajoe
Copy link
Member

@superset unlabel 4.1

@sadpandajoe
Copy link
Member

@supersetbot unlabel 4.1

@github-actions github-actions bot removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 1, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 13, 2024
@kgabryje @sadpandajoe
fix: Use default custom time range time without timezone (#29669)
604fe27 
(cherry picked from commit cd713a2)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:time Related to the time filters in Explore packages size/S 🍒 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgabryje @sadpandajoe @Antonio-RiveroMartnez @michael-s-molina