Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds 4.1.0 RC1 daa to CHANGELOG.md and UPDATING.md #29637

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: Adds 4.1.0 RC1 daa to CHANGELOG.md and UPDATING.md #29637

merged 1 commit into from
Jul 23, 2024

Conversation

sadpandajoe
Copy link
Member

@sadpandajoe sadpandajoe commented Jul 18, 2024 •
edited
Loading

SUMMARY

This PR:

  • Updates CHANGELOG.md and UPDATING.md with 4.1 data.
  • Updates the version in superset-front-end/package.json
  • Adds 4.1.0 to version selector of issue template

NOTE: Release notes are taken care of in this pr: #29262

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the doc Namespace | Anything related to documentation label Jul 18, 2024
@github-actions github-actions bot added dependencies:npm and removed doc Namespace | Anything related to documentation labels Jul 18, 2024
@sadpandajoe sadpandajoe changed the title chore: Add change log for 4.1.0 chore: Add 4.1.0 data to CHANGELOG.md and UPDATING.md Jul 18, 2024
@michael-s-molina michael-s-molina added the hold! On hold label Jul 19, 2024
@michael-s-molina
Copy link
Member

Added the hold label as this PR can only be merged after the release given that we can include more cherries during the RC cycles.

@sadpandajoe sadpandajoe changed the base branch from master to 4.1 July 22, 2024 18:09
@eschutho eschutho removed the hold! On hold label Jul 22, 2024
@eschutho
Copy link
Member

removing the hold tag and we're going to point the pr to the 4.1 branch instead of master and create a new PR for master later.

@eschutho eschutho added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 22, 2024
michael-s-molina
michael-s-molina reviewed Jul 22, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug-report.yml Outdated
@@ -46,6 +46,7 @@ body:
label: Superset version
options:
- master / latest-dev
- "4.1.0"
- "4.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove 4.0.2 as 4.1 will be the supported version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this as part of the master merge branch

michael-s-molina
michael-s-molina reviewed Jul 22, 2024
View reviewed changes
superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadScreenshot.test.tsx Outdated
const mockAddSuccessToast = jest.fn();
const mockAddInfoToast = jest.fn();

jest.spyOn(logging, 'error').mockImplementation(() => {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have code updates in this PR? Are we missing some cherries?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:japanese Translation related to Japanese language labels Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (4.1@6dbfe2a). Learn more about missing BASE report.

Files Patch % Lines
...ents/menu/DownloadMenuItems/DownloadScreenshot.tsx 85.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             4.1   #29637   +/-   ##
======================================
  Coverage       ?   70.42%           
======================================
  Files          ?     1971           
  Lines          ?    78850           
  Branches       ?     8991           
======================================
  Hits           ?    55527           
  Misses         ?    21120           
  Partials       ?     2203
Flag Coverage Δ
hive 49.10% <100.00%> (?)
mysql 76.89% <100.00%> (?)
postgres 76.99% <100.00%> (?)
presto 53.66% <100.00%> (?)
python 83.69% <100.00%> (?)
sqlite 76.47% <100.00%> (?)
unit 59.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed i18n Namespace | Anything related to localization i18n:japanese Translation related to Japanese language labels Jul 22, 2024
@sadpandajoe sadpandajoe changed the title chore: Add 4.1.0 data to CHANGELOG.md and UPDATING.md chore: Adds 4.1.0 RC1 daa to CHANGELOG.md and UPDATING.md Jul 22, 2024
@sadpandajoe
Copy link
Member Author

@eschutho @michael-s-molina I've followed the changes done in the 4.0.0RC1 branch here: beb9ec7. I'll create another PR for the official master merge

@eschutho eschutho merged commit 4369967 into apache:4.1 Jul 23, 2024
31 of 32 checks passed
@eschutho eschutho deleted the joe/4.1-change-logs branch July 23, 2024 01:07
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@sadpandajoe @eschutho
chore: Adds 4.1.0 RC1 daa to CHANGELOG.md and UPDATING.md (#29637)
72d82fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina left review comments

@eschutho eschutho eschutho left review comments

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro

@geido geido Awaiting requested review from geido

@rusackas rusackas Awaiting requested review from rusackas

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@nytai nytai Awaiting requested review from nytai

@craig-rueda craig-rueda Awaiting requested review from craig-rueda

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
dependencies:npm size/XL v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sadpandajoe @michael-s-molina @eschutho @mistercrunch