-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(websocket): add error handling #29538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
@harshit2283 it seems there's a linting error. Can you fix it so we can get this merged? |
Have fixed it. |
btw @harshit2283 as you appear to be using GAQ with websockets, it would be valuable to get your feedback on a recent proposal to simplify the GAQ architecture: #29515 |
@villebro Sure, I will check it out. Thank you! |
SUMMARY
Adding Error handling in websocket to avoid crashing whole service due to a faulty socket etc
Certain Browsers (i.e Safari) don't play nicely with WS Protocol, they can end up crashing the whole service. ref
ADDITIONAL INFORMATION