Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(intro): Add OceanBase to the Supported Databases section of readme.md. #29537

Merged
merged 1 commit into from
Jul 10, 2024
Merged

docs(intro): Add OceanBase to the Supported Databases section of readme.md. #29537

merged 1 commit into from
Jul 10, 2024

Conversation

yuanoOo
Copy link
Contributor

@yuanoOo yuanoOo commented Jul 10, 2024

SUMMARY

Superset already supports OceanBase Database https://superset.apache.org/docs/configuration/databases#oceanbase, now we can add OceanBase to the Supported Databases section of readme.md.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • after

after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the doc Namespace | Anything related to documentation label Jul 10, 2024
@yuanoOo
Copy link
Contributor Author

yuanoOo commented Jul 10, 2024

@zhaoyongjie Can you take a look in your free time.

@zhaoyongjie zhaoyongjie self-requested a review July 10, 2024 11:46
zhaoyongjie
zhaoyongjie approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 17a4537 into apache:master Jul 10, 2024
34 of 36 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@yuanoOo @eschutho
docs(intro): Add OceanBase to the Supported Databases section of read…
8412860 
…me.md. (#29537)
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanoOo @zhaoyongjie