Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more disallowed pg functions #29454

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 2, 2024

SUMMARY

Adds more disallowed functions to postgres

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the data:connect:postgres Related to Postgres label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (76d897e) to head (490c8dc).
Report is 966 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29454       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.21%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37492    -38744     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31381    -14733     
+ Misses      28017     6111    -21906     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.05% <100.00%> (-0.11%) ⬇️
javascript ?
mysql 77.00% <100.00%> (?)
postgres 77.10% <100.00%> (?)
presto 53.67% <100.00%> (-0.13%) ⬇️
python 83.70% <100.00%> (+20.21%) ⬆️
sqlite 76.58% <100.00%> (?)
unit 59.64% <100.00%> (+2.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dpgaspar dpgaspar requested a review from geido July 8, 2024 11:12
@dpgaspar dpgaspar merged commit 0e00282 into apache:master Jul 8, 2024
36 of 37 checks passed
@dpgaspar dpgaspar deleted the fix/add-more-disallowed-functions branch July 8, 2024 13:40
@rusackas rusackas added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 12, 2024
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data:connect:postgres Related to Postgres size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants