-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to NOT LIKE operator #29384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29384 +/- ##
==========================================
+ Coverage 60.48% 70.32% +9.83%
==========================================
Files 1931 1967 +36
Lines 76236 78342 +2106
Branches 8568 8966 +398
==========================================
+ Hits 46114 55095 +8981
+ Misses 28017 21049 -6968
- Partials 2105 2198 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Running CI 🤞 |
I don't understand why fail front end test, my changes not affect to failed tests |
Re-running that one... it might just be flaky, I've seen this one fail randomly before. |
I no have option to re-run |
@rusackas please your help with the pipeline, in my local server all test run OK, I don't understand why fail in test that files that not changed from master |
Running it again... ping me if it flakes out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Change
get_sqla_query
method ofhelpers.py
to supportNOT_LIKE
operatorTESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION