Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(superset-ui-core): Migrate ChartFrame to RTL #28563

Merged
merged 3 commits into from
May 21, 2024
Merged

refactor(superset-ui-core): Migrate ChartFrame to RTL #28563

merged 3 commits into from
May 21, 2024

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented May 17, 2024

SUMMARY

Migrate tests to RTL, refactor to avoid TypeError in ChartFrame render

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added frontend:refactor Related to refactoring the frontend need:tests This PR requires tests labels May 17, 2024
@rtexelm rtexelm changed the title refatcor(superset-ui-core): Migrate ChartFrame to RTL refactor(superset-ui-core): Migrate ChartFrame to RTL May 17, 2024
eschutho
eschutho approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

justinpark
justinpark approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit 0d5aec1 into apache:master May 21, 2024
30 checks passed
Vitor-Avila pushed a commit to Vitor-Avila/superset that referenced this pull request May 28, 2024
@rtexelm @Vitor-Avila
refactor(superset-ui-core): Migrate ChartFrame to RTL (apache#28563)
9c94ba4
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@rtexelm @EnxDev
refactor(superset-ui-core): Migrate ChartFrame to RTL (apache#28563)
f0ea357
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rtexelm
refactor(superset-ui-core): Migrate ChartFrame to RTL (apache#28563)
fcecb9d
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido left review comments

@eschutho eschutho eschutho approved these changes

@justinpark justinpark justinpark approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels frontend:refactor Related to refactoring the frontend need:tests This PR requires tests packages size/L 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rtexelm @justinpark @eschutho @geido @mistercrunch @Antonio-RiveroMartnez