Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix failed docker-build CI job #28442

Merged
merged 2 commits into from
May 13, 2024
Merged

fix(ci): fix failed docker-build CI job #28442

merged 2 commits into from
May 13, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented May 12, 2024 •
edited
Loading

fix(ci): fix failed docker-build CI job due to improper type import in superset-demo-ui

SUMMARY

As above

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
fix(ci): correct module path for @storybook/types used by `superset…
f35beec 
…-demo-ui`

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title fix(ci): correct module path for @storybook/types used by superset-demo-ui fix(ci): fix failed docker-build CI job due to incorrect module path resolution in superset-demo-ui package May 12, 2024
@hainenber hainenber changed the title fix(ci): fix failed docker-build CI job due to incorrect module path resolution in superset-demo-ui package fix(ci): fix failed docker-build CI job May 12, 2024
@hainenber
fix(ci): proper type import from @storybook/types
ab18506 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber marked this pull request as ready for review May 12, 2024 10:57
dpgaspar
dpgaspar approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thank you

@dpgaspar dpgaspar merged commit 4f51f05 into apache:master May 13, 2024
52 of 56 checks passed
@hainenber hainenber deleted the fix-failed-docker-build-in-ci branch May 13, 2024 15:17
aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 13, 2024
@hainenber @aehanno
fix(ci): fix failed docker-build CI job (apache#28442)
ee426d8 
Signed-off-by: hainenber <dotronghai96@gmail.com>
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@hainenber @jzhao62
fix(ci): fix failed docker-build CI job (apache#28442)
f3e40f1 
Signed-off-by: hainenber <dotronghai96@gmail.com>
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@hainenber @EnxDev
fix(ci): fix failed docker-build CI job (apache#28442)
b3c1270 
Signed-off-by: hainenber <dotronghai96@gmail.com>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@hainenber
fix(ci): fix failed docker-build CI job (apache#28442)
0c4b76b 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependencies:npm packages size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @dpgaspar @mistercrunch