Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for catalogs to:
We already have support for Postgres and Databricks.
@john-bodley I'm worried about the DB migration here and how it will affect AirBnB. Can you take a look? The migration needs to:
catalog
column in a few models (SqlaTable
,Query
,SavedQuery
,TabState
, andTableSchema
).schema_perm
column for anySqlaTable
andSlice
models in these databases.schema_perm
.I'm happy to hold back on this PR until we know it's safe to merge to
master
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION