Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cache): correct import of s3cache and THUMBNAIL_CACHE_CONFIG definition #27384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matveykortsev
Copy link

SUMMARY

Fixed outdated doc example for THUMBNAIL_CACHE_CONFIG

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Mar 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley requested a review from sfirke March 4, 2024 18:01
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Mar 4, 2024
@rusackas rusackas requested a review from nytai March 4, 2024 18:40
@sfirke
Copy link
Member

sfirke commented Mar 4, 2024

Thank you for this contribution! I don't have this feature working (we are on Azure, not AWS, and I can't figure out how this would work 😭 ) so I'm no help here. Someone who has thumbnail caching working on AWS should verify.

@rusackas rusackas changed the title docs(cache) correct import of s3cache and THUMBNAIL_CACHE_CONFIG definition docs(cache): correct import of s3cache and THUMBNAIL_CACHE_CONFIG definition Mar 4, 2024
@matveykortsev
Copy link
Author

Im not sure it will work anyways, but with previous example from docs its not even pass db-init job.

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants