Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ID param for DELETE ssh_tunnel endpoint #27130

Merged
merged 7 commits into from
Feb 15, 2024
Merged

fix: ID param for DELETE ssh_tunnel endpoint #27130

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c5de2b
Fix DELETE ssh_tunnel
geido Feb 15, 2024
bf7ccc3
Merge branch 'master' of https://github.com/apache/superset into dieg…
geido Feb 15, 2024
9e8467f
Add breaking change
geido Feb 15, 2024
40543b5
Update test
geido Feb 15, 2024
c71c4ef
Lint
geido Feb 15, 2024
4e4cb0f
Deprecate endpoint
geido Feb 15, 2024
99237e3
Update superset/databases/api.py
geido Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deprecate endpoint
  • Loading branch information
@geido
geido committed Feb 15, 2024
commit 4e4cb0f6acb60d2dd0375183720f931d5a71eb6c
2 changes: 2 additions & 0 deletions superset/databases/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from typing import Any, cast, Optional
from zipfile import is_zipfile, ZipFile

from deprecation import deprecated
from flask import request, Response, send_file
from flask_appbuilder.api import expose, protect, rison, safe
from flask_appbuilder.models.sqla.interface import SQLAInterface
Expand Down Expand Up @@ -1446,6 +1447,7 @@ def validate_parameters(self) -> FlaskResponse:
@expose("/<int:pk>/ssh_tunnel/", methods=("DELETE",))
@protect()
@statsd_metrics
@deprecated(deprecated_in="5.0")
geido marked this conversation as resolved.
Show resolved Hide resolved
@event_logger.log_this_with_context(
action=lambda self, *args, **kwargs: f"{self.__class__.__name__}"
f".delete_ssh_tunnel",
Expand Down
Loading