-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): installing-superset-from-scratch guide gets complete, orderly #27082
base: master
Are you sure you want to change the base?
Conversation
Now guide can be followed directly: `venv` is the only Python environment mentioned, needed environmental variables are stored on a file and sourced from there. All `superset` commands can now be run without interruptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a wonderful PR! People get tripped up by these steps and the way you reordered and added necessary config variables should help a lot. It looks good to me, but I have never actually installed Superset from scratch (I only have deployed with Docker) so don't feel qualified to merge it myself. Hopefully someone else can take a quick peek, agrees with me, and we can merge ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested one comment re: importance of not losing your secret key
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@sfirke Based on the "Installing from Scratch" guide I created Unfortunately it was not possible to create a non-venv In both packages I included a message with the manual steps needed to finalize the installation. |
I think the file this was editing is no longer there, as things got shuffled around a bit. This needs a rebase, but might also need additional tweaking after doing so. I'll convert it to a draft for the moment since it's not mergeable, but I hopeful that we can merge it soon if updates are made :) Thanks for the patience... we drowned in PRs for a bit, and are just coming around to some loose ends. |
Doh, I didn't remember this when I made #28221 which overlaps heavily with this one. We can probably tackle both together. |
Now guide can be followed directly:
venv
is the only Python environment mentioned, needed environmental variables are stored on a file and sourced from there. Allsuperset
commands can now be run without interruptionsSUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION