Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate AlteredSliceTag to typescript #27030

Merged
merged 14 commits into from
Feb 13, 2024
Merged

chore: Migrate AlteredSliceTag to typescript #27030

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7dc1f65
chore: file migration from jsx to tsx
EnxDev Feb 6, 2024
a660b16
chore: Migration
EnxDev Feb 6, 2024
5f45b87
chore: Removed all types any
EnxDev Feb 8, 2024
d590737
Merge branch 'chore/typescript-migration-AlteredSliceTag' of https://…
geido Feb 8, 2024
63a4e4a
Update superset-frontend/src/components/AlteredSliceTag/index.tsx
EnxDev Feb 8, 2024
0864107
Update superset-frontend/src/components/AlteredSliceTag/index.tsx
EnxDev Feb 8, 2024
b093434
Update superset-frontend/src/components/AlteredSliceTag/index.tsx
EnxDev Feb 8, 2024
532b679
chore: Migration js file to ts file
EnxDev Feb 8, 2024
1d99a25
Update superset-frontend/src/components/AlteredSliceTag/index.tsx
EnxDev Feb 9, 2024
ea3d6e8
chore: Enhance types/interfaces
EnxDev Feb 12, 2024
e1be30e
chore: Enhance types/interfaces
EnxDev Feb 12, 2024
b27196e
chore: Enhance types/interfaces
EnxDev Feb 12, 2024
000e621
Merge branch 'chore/typescript-migration-AlteredSliceTag' of https://…
geido Feb 13, 2024
b9305d0
Enhance types
geido Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update superset-frontend/src/components/AlteredSliceTag/index.tsx 
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
  • Loading branch information
@EnxDev @geido
EnxDev and geido authored Feb 8, 2024
commit 0864107007157a9fce849efd9d83443d3dbeec02
2 changes: 1 addition & 1 deletion superset-frontend/src/components/AlteredSliceTag/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class AlteredSliceTag extends React.Component<
return safeStringify(value);
}

renderModalBody(): JSX.Element {
renderModalBody(): React.ReactNode {
const columns = [
{
accessor: 'control',
Expand Down