-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update frozen Python dependencies #26944
chore: Update frozen Python dependencies #26944
Conversation
27948df
to
40dfb5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - oh btw was hoping you would reopen on apache so I can help fix the integration tests failing. I think from this point on I'm always going to work on the main fork as there's only advantages it seems
Looks like some proxy object isn't initializing as expected, that stuff is a bit foreign to me, but can help fixing the issue if needed. |
0c02fe5
to
e19dfe5
Compare
e19dfe5
to
f7c7f5a
Compare
I'm really rather perplexed as to why the tests are failing as Superset (especially the tests) can be rather magical at times. The problem I'm facing is @mock.patch("uuid.uuid4", return_value=UUID)
def test_events(self, mock_uuid4):
app._got_first_request = False
> async_query_manager.init_app(app)
E AttributeError: 'NoneType' object has no attribute 'init_app' where the I've seen other tests which explicitly bind the app to the factor, i.e., adding async_query_manager_factory.init_app(app) fixes the test. The issues however are:
@betodealmeida , @michael-s-molina, or @villebro would you happen to have any insights with regards to these "quirks"? I did look into seeing whether Werkzeug's |
Yeah I spent a moment looking at this and was confused too, something like a non-deterministic sequence of events that's affected by a library upgrade(?) I looked at the libs we're bumping to try and understand any that could have something to do with this, but couldn't think of any while reviewing the list. |
@mistercrunch regarding,
I did the same and couldn't find anything abnormal. I'm still unsure whether there are gremlins in our system and that act of bumping the Python dependencies is actually surfacing these (given that I can't fully grok how the failed test(s) actually pass on |
Ha! Yeah I thought about bissecting the library bumps and then realized life is too short for this nonsense. Can python just support diamond dependencies!? Why can npm do it and not python/pip? Is it that hard of a problem? There's gotta be a PEP for it somewhere. Python 4 here we go!
|
I still get nightmares from the python 3 migrations. Waking up in sweat stressing over breaking thousands of 2.7 installs. |
both @john-bodley and I have tried to fix the pip-compile-multi flow that we need to manage our complex network of python dependencies. Last attempt was here -> #26944 Here I'm reopening the PR on the main fork so we can collaborate on it more easily.
closing in favor of #27404, where we can collab on the main fork |
both @john-bodley and I have tried to fix the pip-compile-multi flow that we need to manage our complex network of python dependencies. Last attempt was here -> #26944 Here I'm reopening the PR on the main fork so we can collaborate on it more easily.
SUMMARY
A rehash of #26913, though with less restrictive additional constraints.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION