Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): Co-habitating/Upgrading Storybooks to v7 (dependency madness ensues) #26907

Merged
merged 88 commits into from
Feb 15, 2024
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
5430bbf
chore(storybook): Upgrading to storybook 7
rusackas Jan 31, 2024
ee76eaa
lots of story tweaks... these might not work ¯\_(ツ)_/¯
rusackas Jan 31, 2024
135c9d9
Revert "lots of story tweaks... these might not work ¯\_(ツ)_/¯"
rusackas Feb 2, 2024
ef6e69d
core stories updated to remove knobs
rusackas Feb 2, 2024
8564de2
turning autodocs off... that sure doesn't work.
rusackas Feb 2, 2024
df1da2d
7.6.12... I mean why not?!
rusackas Feb 2, 2024
2f16a34
removing duplicate addon
rusackas Feb 2, 2024
1011f0b
New MDX loader... working better!
rusackas Feb 2, 2024
6ab7e2a
bumping remark-gfm
rusackas Feb 2, 2024
79b3a43
renaming story so it gets picked up properly by storybook
rusackas Feb 2, 2024
3e04314
Migrating stuff from the monorepo
rusackas Feb 2, 2024
df230d5
fixing path import for SB7 and allowing progressive migration of Stories
rusackas Feb 2, 2024
3c3cdaa
Fixing story sorting for SB7
rusackas Feb 2, 2024
9be4ec0
oops, missed a file... part of the superset-ui-demo bump to 7.6.12
rusackas Feb 2, 2024
e642fd9
fixing filename typo
rusackas Feb 2, 2024
de338d9
ChordChart
rusackas Feb 2, 2024
98f2a9d
CountryMap rename
rusackas Feb 2, 2024
326b52a
partially fixed country map... still getting a weird 404
rusackas Feb 2, 2024
24b635c
ugh... resetting country map
rusackas Feb 2, 2024
40e2386
passing args through ResizableChartDemo properly
rusackas Feb 2, 2024
9112805
fixing warning about multiple children
rusackas Feb 2, 2024
a527432
damned story updates now!
rusackas Feb 2, 2024
f23c6ae
Country map working better than ever!
rusackas Feb 2, 2024
c913121
lots o' linting
rusackas Feb 2, 2024
d48e977
allowing this ridiculous "license" through.
rusackas Feb 2, 2024
f8d1a9b
trying a big den-list string.
rusackas Feb 3, 2024
5046b92
nixing AGPL restriction...
rusackas Feb 3, 2024
aa060d7
removing deny list entirely.
rusackas Feb 3, 2024
8c69666
lots more linting (how were these not caught before!?)
rusackas Feb 3, 2024
9883426
removing migration log... not needed
rusackas Feb 3, 2024
9368867
gitignore future storybook migration logs
rusackas Feb 3, 2024
e399b76
Fixing a few easy-peasy plugins
rusackas Feb 4, 2024
367697b
More easy story conversions
rusackas Feb 4, 2024
9413a66
more working stories
rusackas Feb 4, 2024
a9312e1
Migrating area chart, fixing a bug
rusackas Feb 5, 2024
e9d2fa1
BoxPlot
rusackas Feb 5, 2024
2c7ac51
fixing nav issue
rusackas Feb 5, 2024
43147ac
fixing incorrect import
rusackas Feb 5, 2024
217a90b
area chart categorized correctly
rusackas Feb 5, 2024
0a9ddf1
"fixing" weird circular dependency problem
rusackas Feb 5, 2024
76aad08
Bubble Chart refactor
rusackas Feb 5, 2024
fa6f3ba
adding default form values back without the weird dependency issue.
rusackas Feb 5, 2024
b97ad4b
big number loading, but no trendline?
rusackas Feb 5, 2024
3c7aef6
lint
rusackas Feb 5, 2024
c6a1770
More stories enabled/ported
rusackas Feb 5, 2024
840464a
a few more charts, a few more bugfixes...
rusackas Feb 5, 2024
f755019
moving args/argTypes out of coutryMap
rusackas Feb 5, 2024
4649d28
Pie stories
rusackas Feb 6, 2024
3075135
Radar fixed
rusackas Feb 7, 2024
a1824b7
Sunburst fixed
rusackas Feb 7, 2024
9cf82c6
Series Chart fixed
rusackas Feb 7, 2024
34ceff4
Tree graph refactored
rusackas Feb 7, 2024
a952333
Treemap refactored
rusackas Feb 7, 2024
cb17c67
Waterfall ported
rusackas Feb 7, 2024
c935952
Waterfall needs default colors or it will crash.
rusackas Feb 7, 2024
3bf55dd
linting
rusackas Feb 8, 2024
9f17623
Connection story fixed
rusackas Feb 8, 2024
cb9301c
undoing superchart change
rusackas Feb 8, 2024
aaebf89
Pie story resizes properly finally!
rusackas Feb 8, 2024
7362aaa
linting
rusackas Feb 8, 2024
fb31be8
updated lockfile
rusackas Feb 8, 2024
9cd9d2a
so much linting...
rusackas Feb 8, 2024
63b41ab
last(?) story refactor
rusackas Feb 8, 2024
821fc62
refactorigng `.story` hoisting, killing knobs configs
rusackas Feb 8, 2024
9cfb54c
how did the linter not fix this?!
rusackas Feb 8, 2024
631757f
fixing some more little errors/depdencencies
rusackas Feb 8, 2024
c4bae7e
just a comma... nothing to see here.
rusackas Feb 8, 2024
59320b3
7.6.13 bump
rusackas Feb 8, 2024
b3844c5
7.6.13 bump part 2
rusackas Feb 8, 2024
df333b1
fixing all the resizeable width/height bugs
rusackas Feb 8, 2024
db2b277
adding @typescript-eslint/member-delimiter-style, re-linting
rusackas Feb 9, 2024
e17090b
getting rid of mdx. This commit is a bit of a hot mess.
rusackas Feb 10, 2024
c4df312
even more eslint fun
rusackas Feb 14, 2024
0c1ea82
removing a ts lilnter change since it's just the default
rusackas Feb 14, 2024
1f7229e
removing webpack debug mode
rusackas Feb 14, 2024
0f85049
bumping/fixing eslint-plugin-prettier, eslint-config-prettier
rusackas Feb 14, 2024
66c4f94
Looks like the precommit prettier is right, and npm prettier is wrong ?!
rusackas Feb 14, 2024
b9972c1
adding missing licenses
rusackas Feb 14, 2024
3e7b067
pre-commit prettier at 3.1.0
rusackas Feb 14, 2024
fe946d0
bumping npm prettier to match
rusackas Feb 14, 2024
8cb2b61
more bumpin!
rusackas Feb 14, 2024
94b50af
bumping eslint, ignoring new rules temporarily
rusackas Feb 14, 2024
887473e
restoring file from master
rusackas Feb 14, 2024
e5b2a6c
Merge branch 'master' into upgrade-to-storybook-7
rusackas Feb 14, 2024
c462bff
fixing problematic dependencies
rusackas Feb 14, 2024
3a1b55a
restoring license deny list
rusackas Feb 14, 2024
7c05e91
adding store2@2.14.2 licensing exception
rusackas Feb 14, 2024
1019a4d
comment about license
rusackas Feb 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing story sorting for SB7
  • Loading branch information
rusackas committed Feb 8, 2024
commit 3c3cdaa57311c77b19e1c55297a260e95500d94e
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,22 @@ export const parameters = {
sortStoriesByKind: false,
url: '#',
storySort: (a, b) => {
if (a[1].kind === b[1].kind) {
if (a.kind === b.kind) {
return 0;
}
if (
a[1].id.startsWith('core-packages') &&
!b[1].id.startsWith('core-packages')
a.id.startsWith('core-packages') &&
!b.id.startsWith('core-packages')
) {
return -1;
}
if (
!a[1].id.startsWith('core-packages') &&
b[1].id.startsWith('core-packages')
!a.id.startsWith('core-packages') &&
b.id.startsWith('core-packages')
) {
return 1;
}
return a[1].id.localeCompare(b[1].id, undefined, { numeric: true });
return a.id.localeCompare(b.id, undefined, { numeric: true });
},
},
};
Expand Down