-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Chart menu disable is fixed on chart-fullscreen in issue #25992 #26410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix @sivasathyaseeelan!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26410 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1946 1946
Lines 75990 75993 +3
Branches 8479 8480 +1
=======================================
+ Hits 52544 52547 +3
Misses 21267 21267
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…sue apache#25992 (apache#26410) (cherry picked from commit d0ffe9a)
SUMMARY
This PR solves the issue mentioned in #25992. I have passed zindex of 101 if in fullsize else 99 to NoAnimationDropdown component as dropdownOverlayStyle props from SliceHeaderControls and similarly changed all files which uses NoAnimationDropdown component
BEFORE
Screencast.from.04-01-24.02.26.38.PM.IST.webm
AFTER
Screencast.from.04-01-24.02.28.08.PM.IST.webm
TESTING INSTRUCTIONS
Kindle select any dashboard and use the dropdown menu in top right corner of any graph and select Enter fullscreen. Now u can access the dropdown in fullscreen
ADDITIONAL INFORMATION