Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Chart menu disable is fixed on chart-fullscreen in issue #25992 #26410

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

sivasathyaseeelan
Copy link
Contributor

SUMMARY

This PR solves the issue mentioned in #25992. I have passed zindex of 101 if in fullsize else 99 to NoAnimationDropdown component as dropdownOverlayStyle props from SliceHeaderControls and similarly changed all files which uses NoAnimationDropdown component

BEFORE

Screencast.from.04-01-24.02.26.38.PM.IST.webm

AFTER

Screencast.from.04-01-24.02.28.08.PM.IST.webm

TESTING INSTRUCTIONS

Kindle select any dashboard and use the dropdown menu in top right corner of any graph and select Enter fullscreen. Now u can access the dropdown in fullscreen

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Chart menu is disabled on chart-fullscreen #25992
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @sivasathyaseeelan!

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f6c37e) 69.14% compared to head (10c6a26) 69.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26410   +/-   ##
=======================================
  Coverage   69.14%   69.14%           
=======================================
  Files        1946     1946           
  Lines       75990    75993    +3     
  Branches     8479     8480    +1     
=======================================
+ Hits        52544    52547    +3     
  Misses      21267    21267           
  Partials     2179     2179           
Flag Coverage Δ
javascript 56.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina merged commit d0ffe9a into apache:master Jan 4, 2024
31 checks passed
@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Jan 4, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart menu is disabled on chart-fullscreen
4 participants